UCT/UD: Fix issue N544 (CREQ assert) #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed: - If CREQ and CREP to peer are lost, peer may stay unconnected - type == UCT_UD_PACKET_CREQ assertion
|
Test PASSed. |
|
Test FAILed. |
|
@alex-mikheev, could you please look thru? |
|
Test FAILed. |
| @@ -578,6 +579,9 @@ void uct_ud_ep_process_rx(uct_ud_iface_t *iface, uct_ud_neth_t *neth, unsigned b | |||
| goto out; | |||
| } | |||
| if (neth->packet_type & UCT_UD_PACKET_FLAG_CTL) { | |||
| /* No need to track duplications, CREP always goes | |||
| * with ACK_REQ flag */ | |||
| ep->rx.ooo_pkts.head_sn = neth->psn; | |||
| uct_ud_ep_rx_ctl(iface, ep, (uct_ud_ctl_hdr_t *)(neth + 1)); | |||
There was a problem hiding this comment.
it think it is better to add this line in uct_ud_ep_rx_ctl()
|
Test FAILed. |
|
Test PASSed. |
|
Test PASSed. |
|
👍 |
yosefe
added a commit
to yosefe/ucx
that referenced
this pull request
Sep 11, 2016
Fix issue introduced by openucx#953 - when getting duplicate CREP with lower psn, the current expected psn should not be affected. Otherwise packets already acknowledged would be considered missing.
yosefe
added a commit
to yosefe/ucx
that referenced
this pull request
Sep 11, 2016
Fix issue introduced by openucx#953 - when getting duplicate CREP with lower psn, the current expected psn should not be affected. Otherwise packets already acknowledged would be considered missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
fixes #544